Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed deprecated usage of v8::String::Value constructor #91

Closed
wants to merge 1 commit into from
Closed

Fixed deprecated usage of v8::String::Value constructor #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions v8pp/convert.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ struct convert<std::basic_string<Char, Traits, Alloc>>

if (sizeof(Char) == 1)
{
v8::String::Utf8Value const str(value);
v8::String::Utf8Value const str(isolate, value);
return from_type(reinterpret_cast<Char const*>(*str), str.length());
}
else
{
v8::String::Value const str(value);
v8::String::Value const str(isolate, value);
return from_type(reinterpret_cast<Char const*>(*str), str.length());
}
}
Expand Down