Fixed deprecated usage of v8::String::Value constructor

[atvise]

• v8 has declared the usage of the v8::String::Value constructor without isolate parameter as deprecated therefore add already available isolate as parameter

[pmed]

Hi,

Thank you for the contribution to the project.

There are other deprecated V8 API parts could be used in the library, since I try to support older V8 versions (at least from version 6.0)

I would prefer to stay with this deprecation yet some time, because there is no such a constructor with isolate in V8 version 6.2.

[atvise]

Your welcome!

My suggestion would be a version define switch for such instances. Would that be ok with you ?

Like:

#if V8_MAJOR_VERSION == 6 && V8_MINOR_VERSION <= 0
// code for <= 6.0
#else
// code for >= 6.1 
#endif

[pmed]

I've added isolate argument for v8::String ctors in other places: examples, test.

In V8 version 7.0 this deprecated ctor without isolate was removed. Honestly, I don't want to pollute the code base with #ifdef conditions. Seems that's time to move on, so I'm going to release a new v8pp version with V8 support starting from 6.3.

[pmed]

Hi @atvise,

Thank you, I've manually merged this PR in db0f110

[atvise]

Thx !