feat: use esm-first approach #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
It won't fix #70, I'm opening a PR for that shortly, as it has to be fixed similar to @portabletext/to-html. The problem with #70 is similar to the astro problem we solved for in @sanity/pkg-utils with a related PR in sanity
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
rexxars
force-pushed
the
feat/esm-first
branch
from
6250386 to
431090b
Compare
Ah, makes sense. Thanks for the background! |
stipsan
force-pushed
the
feat/esm-first
branch
from
431090b to
827de22
Compare
stipsan
force-pushed
the
feat/esm-first
branch
from
827de22 to
93e8289
Compare
stipsan
changed the title
stipsan
force-pushed
the
feat/esm-first
branch
from
93e8289 to
2e00860
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be controversial?
Let me know what you think.
Hoping this will solve #70 - but I'm a little unclear about what exactly is causing it.