Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this pattern is used:
astro throws an error as it will use the
node.import
condition and isn't prepared to handle a re-export of CJS:The solution is to add a
node.module
condition beforenode.import
, that has the same value asimport
:This PR adds validation that ensures this pattern, and other
pkg.exports
ordering best practices, are used. And it will throw errors on common mistakes.