Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-610] Converting Loading Inline kit to Typescrit #2328

Merged
merged 3 commits into from
Feb 24, 2023
Merged

[PLAY-610] Converting Loading Inline kit to Typescrit #2328

merged 3 commits into from
Feb 24, 2023

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Feb 22, 2023 •
edited
Loading

Breaking Changes

No

Runway Ticket URL

Runway Ticke

How to test this

Use the Loading Inline kit and ensure it works as expected after Typescript conversion

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 22, 2023
@carloslimasd carloslimasd requested a review from a team as a code owner February 22, 2023 21:58
@carloslimasd carloslimasd self-assigned this Feb 22, 2023
@app-milano app-milano bot temporarily deployed to pr2328 February 22, 2023 22:13 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Feb 24, 2023
@nidaqg nidaqg added this pull request to the merge queue Feb 24, 2023
Merged via the queue into master with commit 3e57ba6 Feb 24, 2023
@nidaqg nidaqg deleted the PLAY-610-ts-conversion-loading-inline branch February 24, 2023 19:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@carloslimasd carloslimasd

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carloslimasd @nidaqg