[PLAY-939] Section Separator Vertical Variant Fixes #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
the
milano
co1in-1ewis
added
the
Product Approved
nidaqg
approved these changes
Apr 26, 2024
nidaqg
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
runway https://nitro.powerhrg.com/runway/backlog_items/PLAY-939
the vertical section separator doesn't show up on fire fox because fire fox is rounding down on a 1px width
using width of 1.9 forces the width to be greater than 1 but less than 2 which should result in 1px all the time
Screenshots: Screenshots to visualize your addition/change
check it out here https://pr3370.playbook.beta.px.powerapp.cloud/kits/section_separator/react#vertical