Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for parting rooms via interop + adjust responses #11811

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Jan 23, 2025

Builds on top of #11786

osu-server-spectator:

  • Will call the new endpoint to part rooms.
  • Only needs the room ID when creating rooms, as it does a DB lookup of its own. I want to avoid deserialising osu!web models here because that stuff is messy osu!-side.
  • Does not need a resultant value returned from joining/parting rooms.

@smoogipoo smoogipoo changed the title Add support for parting rooms via LIO + adjust responses Add support for parting rooms via interop + adjust responses Jan 23, 2025
Comment on lines +141 to 144
$currentUser = \Auth::user();
// this allows admins/host/whoever to remove users from games in the future
if (get_int($userId) !== auth()->user()->user_id) {
if (get_int($userId) !== $currentUser->getKey()) {
abort(403);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted to follow the same structure as join(), which I assume was adjusted for a reason in #11786.

@nanaya nanaya merged commit 7c100f9 into ppy:master Jan 23, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants