Create, join, and part multiplayer rooms only via the multiplayer server #31637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant functionality has been removed from `RoomManager` in the process.
In particular, when the exception is:
`AggregateException { AggregateException { HubException } }`,
then the existing code will only unwrap the first aggregate exception.
The overlay's code was copied from the extension so both have been
adjusted here.
1 task
|
As a heads up, I'll review this but won't merge until after the imminent release. |
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osu-server-spectatoris now the authority in creating multiplayer rooms. Most of the complexity of this PR is a result ofRoomManagerno longer having the ability to create/join/part rooms, which is now handled either by the multiplayer server or by API requests (for playlists + daily challenge).MultiplayerRoomManagerno longer exists, and I expectRoomManagerto go away in the near future too. I'd actually already started down that path but wanted to keep this PR somewhat lean, and so I've only added an XMLDoc onRoomManagermentioning this.