-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
requirements-txt-fixer doesn't handle new pkg_resources==0.0.0 #1030
Comments
ericfrederich
added a commit
to ericfrederich/pre-commit-hooks
that referenced
this issue
Mar 26, 2024
This package with an underscore instead of a dash seems to be new behavior (at least on Ubuntu 20.04 with Python 3.8) fixes pre-commit#1030
It's easy to demonstrate this using Docker to run the old OS. What you'll see at the end when you run the below command is docker run --rm ubuntu:20.04 \
/bin/bash -c \
'apt update && apt upgrade -y && apt install -y python3 python3-venv &&
python3 -m venv /tmp/delete-me-venv &&
source /tmp/delete-me-venv/bin/activate &&
pip install --upgrade pip wheel &&
echo requirements... &&
pip freeze' |
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this issue
Oct 9, 2024
… (hetznercloud/fleeting-plugin-hetzner!125) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v4.6.0` -> `v5.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v5.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0): pre-commit-hooks v5.0.0 [Compare Source](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) ##### Features - `requirements-txt-fixer`: also remove `pkg_resources==...`. - [#​850](pre-commit/pre-commit-hooks#850) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​1030](pre-commit/pre-commit-hooks#1030) issue by [@​ericfrederich](https://github.com/ericfrederich). - `check-illegal-windows-names`: new hook! - [#​1044](pre-commit/pre-commit-hooks#1044) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​589](pre-commit/pre-commit-hooks#589) issue by [@​ericfrederich](https://github.com/ericfrederich). - [#​1049](pre-commit/pre-commit-hooks#1049) MR by [@​Jeffrey-Lim](https://github.com/Jeffrey-Lim). - `pretty-format-json`: continue processing even if a file has a json error. - [#​1039](pre-commit/pre-commit-hooks#1039) MR by [@​amarvin](https://github.com/amarvin). - [#​1038](pre-commit/pre-commit-hooks#1038) issue by [@​amarvin](https://github.com/amarvin). ##### Fixes - `destroyed-symlinks`: set `stages` to `[pre-commit, pre-push, manual]` - MR [#​1085](pre-commit/pre-commit-hooks#1085) by [@​AdrianDC](https://github.com/AdrianDC). ##### Migrating - pre-commit-hooks now requires `pre-commit>=3.2.0`. - use non-deprecated names for `stages`. - [#​1093](pre-commit/pre-commit-hooks#1093) MR by [@​asottile](https://github.com/asottile). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Perhaps something changed on PyPI but instead of Ubuntu 20.04 generating
pkg-resources==0.0.0
it now generatesnpkg_resources==0.0.0
which should also be ignored.The text was updated successfully, but these errors were encountered: