-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add check for illegal Windows filenames #589
Comments
seems like a good idea in line with the spirit of the repository! 👍 |
i would suggest splitting the check between Win32 and WinNT, even if WinObj does a good job |
@theGASK sorry what? |
Any progress on this? |
Just needs to be merged. It's a new standalone check. |
the PR has a bunch of un-addressed feedback |
@asottile Would you want somebody to pick up the PR you already reviewed or prefer if somebody worked on the |
the original author seems to not be interested in fixing their PR so yeah I would appreciate a new one -- probably just |
+1 on this :) I would also suggest checking for characters which cannot be used on windows, such as By the way this is a problem in WSL which has led to a lot of pain for me in the past. One contributor had committed a |
… (hetznercloud/fleeting-plugin-hetzner!125) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v4.6.0` -> `v5.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v5.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0): pre-commit-hooks v5.0.0 [Compare Source](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) ##### Features - `requirements-txt-fixer`: also remove `pkg_resources==...`. - [#​850](pre-commit/pre-commit-hooks#850) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​1030](pre-commit/pre-commit-hooks#1030) issue by [@​ericfrederich](https://github.com/ericfrederich). - `check-illegal-windows-names`: new hook! - [#​1044](pre-commit/pre-commit-hooks#1044) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​589](pre-commit/pre-commit-hooks#589) issue by [@​ericfrederich](https://github.com/ericfrederich). - [#​1049](pre-commit/pre-commit-hooks#1049) MR by [@​Jeffrey-Lim](https://github.com/Jeffrey-Lim). - `pretty-format-json`: continue processing even if a file has a json error. - [#​1039](pre-commit/pre-commit-hooks#1039) MR by [@​amarvin](https://github.com/amarvin). - [#​1038](pre-commit/pre-commit-hooks#1038) issue by [@​amarvin](https://github.com/amarvin). ##### Fixes - `destroyed-symlinks`: set `stages` to `[pre-commit, pre-push, manual]` - MR [#​1085](pre-commit/pre-commit-hooks#1085) by [@​AdrianDC](https://github.com/AdrianDC). ##### Migrating - pre-commit-hooks now requires `pre-commit>=3.2.0`. - use non-deprecated names for `stages`. - [#​1093](pre-commit/pre-commit-hooks#1093) MR by [@​asottile](https://github.com/asottile). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
There are file and directory names which are legal in Git and most operating systems but illegal in Windows. They should be avoided in case a developer happens to use Windows.
The following names are illegal as bare names as well as with extensions regardless of case for files or directories. For instance
CoM6
,cOm6.txt
,com6.foo.jpg
, etc are all illegal. Windows will refuse to create those files if you try to check them out.From: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file
The text was updated successfully, but these errors were encountered: