Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove _nextDom usage #4553

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Remove _nextDom usage #4553

merged 1 commit into from
Nov 22, 2024

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 11, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-7.98ms - +1.31ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.07ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.54ms - +0.77ms)
    preact-local vs preact-main
  • many-updates: faster ✔ 2% - 7% (0.32ms - 1.25ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.56ms - +1.57ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.06ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +0% (-1.05ms - +0.03ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +4% (-0.31ms - +1.42ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: faster ✔ 2% - 2% (0.44ms - 0.45ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +0% (-0.04ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +5% (-0.17ms - +0.84ms)
    preact-local vs preact-main
  • many-updates: faster ✔ 2% - 2% (0.07ms - 0.09ms)
    preact-local vs preact-main
  • replace1k: faster ✔ 1% - 2% (0.04ms - 0.07ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 0% - 2% (0.01ms - 0.06ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local930.84ms - 935.93ms-unsure 🔍
-1% - +0%
-7.98ms - +1.31ms
preact-main932.83ms - 940.61msunsure 🔍
-0% - +1%
-1.31ms - +7.98ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local24.84ms - 24.84ms-faster ✔
2% - 2%
0.44ms - 0.45ms
preact-main25.29ms - 25.29msslower ❌
2% - 2%
0.44ms - 0.45ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.64ms-unsure 🔍
-0% - +0%
-0.07ms - +0.03ms
preact-main16.59ms - 16.66msunsure 🔍
-0% - +0%
-0.03ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.65ms - 1.68ms-unsure 🔍
-2% - +0%
-0.04ms - +0.00ms
preact-main1.67ms - 1.69msunsure 🔍
-0% - +2%
-0.00ms - +0.04ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.65ms - 75.78ms-unsure 🔍
-2% - +1%
-1.54ms - +0.77ms
preact-main74.59ms - 76.61msunsure 🔍
-1% - +2%
-0.77ms - +1.54ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local15.53ms - 16.22ms-unsure 🔍
-1% - +5%
-0.17ms - +0.84ms
preact-main15.17ms - 15.90msunsure 🔍
-5% - +1%
-0.84ms - +0.17ms
-
many-updates
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4060
  • Commit: 8649719

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.44ms - 15.99ms-faster ✔
2% - 7%
0.32ms - 1.25ms
preact-main16.12ms - 16.88msslower ❌
2% - 8%
0.32ms - 1.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.50ms - 4.52ms-faster ✔
2% - 2%
0.07ms - 0.09ms
preact-main4.58ms - 4.60msslower ❌
2% - 2%
0.07ms - 0.09ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.65ms - 76.29ms-unsure 🔍
-1% - +2%
-0.56ms - +1.57ms
preact-main74.29ms - 75.64msunsure 🔍
-2% - +1%
-1.57ms - +0.56ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.55ms - 3.57ms-faster ✔
1% - 2%
0.04ms - 0.07ms
preact-main3.59ms - 3.62msslower ❌
1% - 2%
0.04ms - 0.07ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.70ms - 32.47ms-faster ✔
0% - 3%
0.06ms - 1.14ms
preact-main32.31ms - 33.06msslower ❌
0% - 4%
0.06ms - 1.14ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local38.63ms - 39.97ms-slower ❌
0% - 5%
0.04ms - 1.94ms
preact-main37.63ms - 38.99msfaster ✔
0% - 5%
0.04ms - 1.94ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local32.01ms - 33.01ms-unsure 🔍
-3% - +2%
-0.98ms - +0.57ms
preact-main32.12ms - 33.31msunsure 🔍
-2% - +3%
-0.57ms - +0.98ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.47ms - 24.99ms-unsure 🔍
-2% - +2%
-0.40ms - +0.48ms
preact-main24.33ms - 25.04msunsure 🔍
-2% - +2%
-0.48ms - +0.40ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.33ms - 23.56ms-unsure 🔍
-1% - +0%
-0.33ms - +0.01ms
preact-main23.48ms - 23.73msunsure 🔍
-0% - +1%
-0.01ms - +0.33ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.62ms - 22.47ms-unsure 🔍
-2% - +3%
-0.35ms - +0.73ms
preact-main21.52ms - 22.19msunsure 🔍
-3% - +2%
-0.73ms - +0.35ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4060
  • Commit: 8649719

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.07ms - 2.19ms-unsure 🔍
-3% - +5%
-0.06ms - +0.10ms
preact-main2.06ms - 2.16msunsure 🔍
-4% - +3%
-0.10ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.10ms - 1.11ms-unsure 🔍
-1% - +0%
-0.01ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - +1%
-0.00ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.66ms - 34.05ms-unsure 🔍
-3% - +0%
-1.05ms - +0.03ms
preact-main33.86ms - 34.86msunsure 🔍
-0% - +3%
-0.03ms - +1.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.23ms-unsure 🔍
-2% - +1%
-0.02ms - +0.01ms
preact-main1.22ms - 1.24msunsure 🔍
-1% - +2%
-0.01ms - +0.02ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.90ms - 36.21ms-unsure 🔍
-1% - +4%
-0.31ms - +1.42ms
preact-main34.43ms - 35.57msunsure 🔍
-4% - +1%
-1.42ms - +0.31ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.48ms - 3.52ms-faster ✔
0% - 2%
0.01ms - 0.06ms
preact-main3.52ms - 3.55msslower ❌
0% - 2%
0.01ms - 0.06ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Nov 11, 2024

Size Change: -9 B (-0.01%)

Total Size: 62.2 kB

Filename Size Change
dist/preact.js 4.69 kB +2 B (+0.04%)
dist/preact.min.js 4.71 kB -3 B (-0.06%)
dist/preact.min.module.js 4.72 kB +1 B (+0.02%)
dist/preact.min.umd.js 4.74 kB -1 B (-0.02%)
dist/preact.module.js 4.71 kB +5 B (+0.11%)
dist/preact.umd.js 4.75 kB -4 B (-0.08%)
jsx-runtime/dist/jsxRuntime.js 973 B -3 B (-0.31%)
jsx-runtime/dist/jsxRuntime.module.js 947 B -2 B (-0.21%)
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB -4 B (-0.38%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 11, 2024

Coverage Status

coverage: 99.487% (+0.001%) from 99.486%
when pulling 8649719 on remove-next-dom
into 33a688f on main.

Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yea the perf change is weird but this is a good change regardless I think. We can investigate that later

@JoviDeCroock JoviDeCroock force-pushed the remove-next-dom branch 2 times, most recently from 6ba8900 to c13793c Compare November 12, 2024 17:21
@JoviDeCroock JoviDeCroock merged commit 6590e26 into main Nov 22, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the remove-next-dom branch November 22, 2024 07:27
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants