Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

10.25.1 #4589

Merged
merged 1 commit into from
Dec 2, 2024
Merged

10.25.1 #4589

merged 1 commit into from
Dec 2, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Dec 1, 2024

Fixes

Types

Maintenance

Copy link

github-actions bot commented Dec 1, 2024

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +1% (-3.84ms - +5.52ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.07ms - +0.06ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-2.29ms - +0.75ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +5% (-0.46ms - +0.72ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.76ms - +0.53ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +7% (-0.03ms - +0.15ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.75ms - +0.23ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.25ms - +1.02ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +4% (-0.33ms - +0.46ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local936.02ms - 943.35ms-unsure 🔍
-0% - +1%
-3.84ms - +5.52ms
preact-main935.93ms - 941.76msunsure 🔍
-1% - +0%
-5.52ms - +3.84ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local24.84ms - 24.86ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main24.84ms - 24.86msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.65ms-unsure 🔍
-0% - +0%
-0.07ms - +0.06ms
preact-main16.57ms - 16.67msunsure 🔍
-0% - +0%
-0.06ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.65ms - 1.68ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main1.66ms - 1.69msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.43ms - 75.69ms-unsure 🔍
-3% - +1%
-2.29ms - +0.75ms
preact-main74.31ms - 76.34msunsure 🔍
-1% - +3%
-0.75ms - +2.29ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local11.17ms - 11.67ms-unsure 🔍
-3% - +4%
-0.33ms - +0.46ms
preact-main11.05ms - 11.66msunsure 🔍
-4% - +3%
-0.46ms - +0.33ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.58ms - 16.39ms-unsure 🔍
-3% - +5%
-0.46ms - +0.72ms
preact-main15.43ms - 16.28msunsure 🔍
-4% - +3%
-0.72ms - +0.46ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.50ms - 4.53ms-unsure 🔍
-0% - +1%
-0.02ms - +0.02ms
preact-main4.50ms - 4.53msunsure 🔍
-0% - +0%
-0.02ms - +0.02ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4150
  • Commit: 573de58

duration

VersionAvg timevs preact-localvs preact-main
preact-local65.67ms - 66.62ms-unsure 🔍
-1% - +1%
-0.76ms - +0.53ms
preact-main65.82ms - 66.69msunsure 🔍
-1% - +1%
-0.53ms - +0.76ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.58ms - 3.61ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main3.58ms - 3.61msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.16ms - 31.26ms-unsure 🔍
-2% - +3%
-0.51ms - +0.88ms
preact-main30.11ms - 30.95msunsure 🔍
-3% - +2%
-0.88ms - +0.51ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.63ms - 37.15ms-unsure 🔍
-4% - +2%
-1.39ms - +0.90ms
preact-main35.78ms - 37.49msunsure 🔍
-2% - +4%
-0.90ms - +1.39ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.54ms - 30.70ms-unsure 🔍
-1% - +4%
-0.34ms - +1.18ms
preact-main29.21ms - 30.18msunsure 🔍
-4% - +1%
-1.18ms - +0.34ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local22.46ms - 22.90ms-unsure 🔍
-2% - +1%
-0.38ms - +0.23ms
preact-main22.55ms - 22.96msunsure 🔍
-1% - +2%
-0.23ms - +0.38ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.00ms - 21.25ms-unsure 🔍
-1% - +1%
-0.22ms - +0.14ms
preact-main21.04ms - 21.29msunsure 🔍
-1% - +1%
-0.14ms - +0.22ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.03ms - 20.68ms-unsure 🔍
-2% - +2%
-0.43ms - +0.42ms
preact-main20.09ms - 20.63msunsure 🔍
-2% - +2%
-0.42ms - +0.43ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #4150
  • Commit: 573de58

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.07ms - 2.21ms-unsure 🔍
-1% - +7%
-0.03ms - +0.15ms
preact-main2.02ms - 2.14msunsure 🔍
-7% - +1%
-0.15ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.13ms - 33.83ms-unsure 🔍
-2% - +1%
-0.75ms - +0.23ms
preact-main33.40ms - 34.08msunsure 🔍
-1% - +2%
-0.23ms - +0.75ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.24ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.22ms - 1.23msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.77ms - 35.36ms-unsure 🔍
-4% - +3%
-1.25ms - +1.02ms
preact-main33.87ms - 35.49msunsure 🔍
-3% - +4%
-1.02ms - +1.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.47ms - 3.50ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main3.48ms - 3.51msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Dec 1, 2024

Size Change: 0 B

Total Size: 62.3 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.2 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.71 kB
dist/preact.min.js 4.73 kB
dist/preact.min.module.js 4.73 kB
dist/preact.min.umd.js 4.75 kB
dist/preact.module.js 4.73 kB
dist/preact.umd.js 4.77 kB
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 973 B
jsx-runtime/dist/jsxRuntime.module.js 947 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Dec 1, 2024

Coverage Status

coverage: 99.617%. remained the same
when pulling 4059674 on 10.25.1
into 04684dd on main.

@rschristian
Copy link
Member

Mind waiting for me to check the ElementRef PR to see if we can add it? I'll be home in ~30 min to see if everything is good there now that the type resolution has been set up for it

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoviDeCroock JoviDeCroock merged commit 80d9226 into main Dec 2, 2024
13 checks passed
@JoviDeCroock JoviDeCroock deleted the 10.25.1 branch December 2, 2024 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants