Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pre poketch display #378

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Pre poketch display #378

merged 5 commits into from
Feb 14, 2025

Conversation

lucie-sharpe
Copy link
Contributor

I am not sure if i have handled the always true function correctly. It is called in multiple if conditionals. Also i used some macros to define NARC parameters is this the correct way to do this? Should the overlay24/ folder be renamed?

Copy link
Collaborator

@lhearachel lhearachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for digging into this! 👍 I have some collaborative thoughts below.

@lhearachel lhearachel merged commit 7b2b89d into pret:main Feb 14, 2025
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants