Poketch digital clock app #388
Conversation
# Conflicts: # src/overlay026/ov26_02256404.c
# Conflicts: # src/overlay026/ov26_022561C0.c # src/overlay026/ov26_02256404.c
|
|
||
| #define NUM_TASK_SLOTS 8 | ||
|
|
||
| #define POKETCH_CLOCK_DIGITS_TILEMAP_IDX 25 |
There was a problem hiding this comment.
This should probably be defined somewhere else together for all indexes of files in graphic/poketch.narc, but idk where would be appropriate.
There was a problem hiding this comment.
@lhearachel commented on #378 "These are fine for now, but we will want to replace them with an naix generated by re-packing this NARC once we unpack them into the resource tree."
I am not sure about the process of unpacking NARCs into the resource tree.
There was a problem hiding this comment.
Unpacking is a bit of a process unto itself, but probably one that we should do sooner rather than later, since there are multiple hands touching the Poketch subsystem at the moment. A lot of it is going to be manual work and tinkering to figure out what values align with what using a previewer like Tinke or some-such.
platinum.us/main.lsf
Outdated
| @@ -878,11 +878,11 @@ Overlay overlay25 | |||
| Object main.nef.p/src_overlay025_ov25_02255DBC.c.o | |||
| } | |||
|
|
|||
| Overlay overlay26 | |||
| Overlay poketch_digital_clock | |||
There was a problem hiding this comment.
thought: I'm making a note for myself whenever I get back onto source-tree reorganization that the poketch is sufficiently large as to deserve its own top-level folder (similar to field, battle, and contest).
|
I have made the changes suggested. I did not feel a constants file was needed so i have just used the local header file. Tell me what you think of the naming conventions used? |
Documented OV26 which is the digital clock app on the poketch. Some more work could be done on the function
PoketchDigitalClock_CopyDigitTilemapinpoketch_digital_clock_graphics.c