fix: npm ignore __tests__ & stories

[andykenward]

When compiling dist:transpile:cjs or dist:transpile:esm babel is including the folders __tests__ & stories in the output. But we don't want to publish those files to npm. Adding those folders to ignore in the package.json files array should solve this.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 80be3a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/5iKn8hDHSZGDVeDF7UCQHFTesfR6
✅ Preview: https://primer-components-git-fork-andykenward-babel-buil-5a92af-primer.vercel.app

[colebemis]

Thanks for the PR, @andykenward ❤️ Could you elaborate on what you mean by "dist:types is generating type definitions for the same folders"?

[andykenward]

Sorry, I deleted the scripts dist:types by mistake.

But I mean't that when you run yarn dist:types it generates TypeScript definitions for the __tests__ & stories folders. Which seems pointless.

[colebemis]

Ah, I see. We do want to type check the tests and the stories but we ignore those files when publishing to npm: https://github.com/primer/components/blob/3af005c6ec7d0900cc46728d5c725887bf7ba57c/package.json#L41-L42

[andykenward]

Ah, I see. We do want to type check the tests and the stories but we ignore those files when publishing to npm:

https://github.com/primer/components/blob/3af005c6ec7d0900cc46728d5c725887bf7ba57c/package.json#L41-L42

Perhaps also add the compiled stories folder to be ignored too, as this is only for storybookjs?

 "!lib/stories", 
 "!lib-esm/stories" 

[colebemis]

@andykenward Great idea!

[andykenward]

@colebemis Sorry in the delay in this pull request. I've made the discussed changes.

[colebemis]

🚀