Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix/post review #119

Merged
merged 18 commits into from
Apr 11, 2024
Merged

Fix/post review #119

merged 18 commits into from
Apr 11, 2024

Conversation

clemlak
Copy link
Contributor

@clemlak clemlak commented Apr 5, 2024

This PR contains the post review fixes, cf #89.

@clemlak clemlak self-assigned this Apr 5, 2024
@clemlak clemlak added 📃 contracts Anything related to the DFMM contracts (or strategies) 🔨 audit fix Patching audit findings labels Apr 5, 2024
@clemlak clemlak requested review from Alexangelj and kinrezC April 5, 2024 10:32
@clemlak clemlak added the 🚧 DO NOT MERGE 🚧 Do not merge label Apr 5, 2024
clemlak and others added 15 commits April 5, 2024 15:17
@clemlak
feat: remove computeSwapDeltaLiquidity from ConstantSumSolver simulat…
016b81a 
…eSwap
@clemlak
feat: remove SimulateSwapState in ConstantSumSolver simulateSwap
348dbed
@clemlak
fix: wrap for loop with unchecked to save some gas
50d121a
@clemlak
fix: skip transfer if amount is 0
c086b1b
@Alexangelj
fix(DOS): cross pool dos vector removed by refunding eth only if weth…
38917c1 
… token
@Alexangelj
fix(native-eth): use msg.value to determine branch case, refund exces…
624a29a 
…s amounts
@clemlak
Merge branch 'fix/post-review' into fix/native-eth
bd0222f
@clemlak
Merge pull request #122 from primitivefinance/fix/native-eth
54f0e2a 
fix(DOS): cross pool dos vector removed by refunding eth only if weth…
@clemlak
fix: use ONE constant instead of actual value in G3M trading function
1009b0f
@clemlak
fix: change rounding direction in NTokenG3M trading function
cc42a4e
@clemlak
fix: change rounding direction in NTokenG3M computeSwapDeltaLiquidity
039093f
@clemlak
fix: use mulDiv in NTokenG3M computeDeltaGivenDeltaLR
754916c
@clemlak
fix: computeSwapDeltaLiquidity in ConstantSumMath
6b5a3f5
@clemlak
fix: add rounding direction for ConstantSum computeDeltaLiquidity
54d10bb
@clemlak
fix: compute delta liquidity in ConstantSum with different rounding d…
1e51776 
…irections
@clemlak clemlak merged commit 4e207a7 into main Apr 11, 2024
6 checks passed
@clemlak clemlak deleted the fix/post-review branch April 11, 2024 22:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alexangelj Alexangelj Alexangelj approved these changes

@kinrezC kinrezC Awaiting requested review from kinrezC

Assignees

@clemlak clemlak

Labels
🔨 audit fix Patching audit findings 📃 contracts Anything related to the DFMM contracts (or strategies) 🚧 DO NOT MERGE 🚧 Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemlak @Alexangelj