Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update nodejs to v22 #295

Closed
wants to merge 2 commits into from
Closed

update nodejs to v22 #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9d82d
update nodejs to v22
Nexucis Feb 6, 2025
6028e43
update nodejs to v22 in base image 1.22
Nexucis Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 1.22/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ RUN \
yamllint \
openssh-client \
&& git config --system --add safe.directory "*" \
&& curl -s -f -L https://deb.nodesource.com/gpgkey/nodesource.gpg.key -o /etc/apt/trusted.gpg.d/nodesource.asc \
&& echo "deb https://deb.nodesource.com/node_20.x/ bookworm main" > /etc/apt/sources.list.d/nodesource.list \
&& curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \
&& bash nodesource_setup.sh \
&& apt-get update \
&& apt-get install -y --no-install-recommends nodejs \
&& yq_file=$(/bin/download.sh ${YQ_URL} ${YQ_SUM}) \
Expand Down
4 changes: 2 additions & 2 deletions 1.23/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ RUN \
yamllint \
openssh-client \
&& git config --system --add safe.directory "*" \
&& curl -s -f -L https://deb.nodesource.com/gpgkey/nodesource.gpg.key -o /etc/apt/trusted.gpg.d/nodesource.asc \
&& echo "deb https://deb.nodesource.com/node_20.x/ bookworm main" > /etc/apt/sources.list.d/nodesource.list \
&& curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would much prefer to not use the script setup like this. Is there a reason the previous apt method doesn't work anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's because it doesn't exist unfortunately :(

&& bash nodesource_setup.sh \
&& apt-get update \
&& apt-get install -y --no-install-recommends nodejs \
&& yq_file=$(/bin/download.sh ${YQ_URL} ${YQ_SUM}) \
Expand Down