Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update nodejs to v22 #295

Closed
wants to merge 2 commits into from
Closed

update nodejs to v22 #295

wants to merge 2 commits into from

Conversation

Nexucis
Copy link
Member

@Nexucis Nexucis commented Feb 6, 2025

No description provided.

Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
@Nexucis Nexucis force-pushed the nexucis/update-nodejs branch from 8826278 to fa9d82d Compare February 6, 2025 14:30
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the 1.22/base/Dockerfile to match? Even if we don't use it by default, I prefer to keep them consistent.

@@ -26,8 +26,8 @@ RUN \
yamllint \
openssh-client \
&& git config --system --add safe.directory "*" \
&& curl -s -f -L https://deb.nodesource.com/gpgkey/nodesource.gpg.key -o /etc/apt/trusted.gpg.d/nodesource.asc \
&& echo "deb https://deb.nodesource.com/node_20.x/ bookworm main" > /etc/apt/sources.list.d/nodesource.list \
&& curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would much prefer to not use the script setup like this. Is there a reason the previous apt method doesn't work anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that's because it doesn't exist unfortunately :(

Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
@Nexucis
Copy link
Member Author

Nexucis commented Feb 6, 2025

closing this PR in favor of #296

@Nexucis Nexucis closed this Feb 6, 2025
@Nexucis Nexucis deleted the nexucis/update-nodejs branch February 6, 2025 15:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants