Merge pull request #87 from modosc/fix-slug-parsing

handle github remote urls without .git suffix
prontolabs · Sep 20, 2015 · c635341 · c635341
2 parents 27b2de2 + ce35e6b
commit c635341
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/pronto/github.rb b/lib/pronto/github.rb
@@ -37,7 +37,7 @@ def create_pull_comment(comment)
     def slug
       @slug ||= begin
         @repo.remote_urls.map do |url|
-          match = /.*github.com(:|\/)(?<slug>.*).git/.match(url)
+          match = /.*github.com(:|\/)(?<slug>.*?)(?:\.git)?\z/.match(url)
           match[:slug] if match
         end.compact.first
       end

diff --git a/spec/pronto/github_spec.rb b/spec/pronto/github_spec.rb
@@ -8,6 +8,23 @@ module Pronto
     let(:sha) { '61e4bef' }
     let(:comment) { double(body: 'note', path: 'path', line: 1, position: 1) }
 
+    describe '#slug' do
+      let(:repo) { double(remote_urls: ['git@github.com:mmozuras/pronto']) }
+      subject { github.commit_comments(sha) }
+
+      context 'git remote without .git suffix' do
+        specify do
+          Octokit::Client.any_instance
+            .should_receive(:commit_comments)
+            .with('mmozuras/pronto', sha)
+            .once
+            .and_return([comment])
+
+          subject
+        end
+      end
+    end
+
     describe '#commit_comments' do
       subject { github.commit_comments(sha) }