Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

handle github remote urls without .git suffix #87

Merged
merged 1 commit into from
Sep 20, 2015
Merged

handle github remote urls without .git suffix #87

merged 1 commit into from
Sep 20, 2015

Conversation

modosc
Copy link
Contributor

@modosc modosc commented Aug 26, 2015

Github#slug doesn't correctly parse remote urls if they don't end in .git even though cloning from github (at least, haven't tested any other servers) works happily with the same urls. if this is a universal thing i'm happy to make the same change for gitlab as well.

@mmozuras
Copy link
Member

mmozuras commented Sep 6, 2015

@modosc could you add an entry to CHANGELOG? 😄

mmozuras added a commit that referenced this pull request Sep 20, 2015
handle github remote urls without .git suffix
@mmozuras mmozuras merged commit c635341 into prontolabs:master Sep 20, 2015
@mmozuras
Copy link
Member

@modosc updated CHANGELOG myself, no worries 😄

Thanks 🙇

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants