-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Importing types from pubnub #405
Comments
@Tallyb thank you for reaching out to us. Interfaces built for quite a long time and served with the package itself, but for some reason Do you experience issues with types which you used before, and they become unavailable / changed with this major version? We will double-check from our side whether it was intentional or something managed to slip from our attention. 8.2.8 mostly has been targeting fixes to the subscription shared worker. Best regards. |
There really were major changes, but all of them happened with the 8.0.0 release. |
well, in 8.0.0 types entry in package.json was not set, hence you could continue and use DT. The change made in 8.2.8 basically overrides the DT types. Hence the change became effective only on the current release.
types are used in rxjs subscription and other. Can you suggest what is the correct way to do this post 8.x and which types are no longer supported, if any? |
Looks like we will need to add post-processing for generated types files to merge them into one to mimic type as it was with
On next week, we will try (depends on from backlog) to provide a release with types which has all public types under |
Hello, any updates? this is quite blocking for us .... Thanks |
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
starting 8.2.8 a major change was made (should not hide behind a patch version) that types are now used from internal library instead of using definitely typed.
Can you please document on the proper way to import from the library? Also - are all the types that existed in DT still supported?
It seems like some types are not exported.
The text was updated successfully, but these errors were encountered: