Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Incorrect history Actions type #407

Closed
yo1dog opened this issue Oct 14, 2024 · 1 comment · Fixed by #417
Closed

Incorrect history Actions type #407

yo1dog opened this issue Oct 14, 2024 · 1 comment · Fixed by #417
Assignees
@parfeon
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: in progress This issue is being worked on. type: fix This PR contains fixes to existing features.

Comments

@yo1dog
Copy link

yo1dog commented Oct 14, 2024

The current typing for the history Actions interface is wrong. It defines the action value as an object when it is actually an array of objects.

javascript/src/core/types/api/history.ts

Lines 134 to 144 in 0beda2c

[v: string]: {
/**
* Unique identifier of the user which reacted on message.
*/
uuid: string;
/**
* High-precision PubNub timetoken with time when {@link uuid} reacted on message.
*/
actionTimetoken: string;
};

@parfeon parfeon self-assigned this Oct 30, 2024
@parfeon parfeon added status: in progress This issue is being worked on. priority: medium This PR should be reviewed after all high priority PRs. type: fix This PR contains fixes to existing features. labels Oct 30, 2024
parfeon added a commit that referenced this issue Oct 30, 2024
@parfeon
fix(types): fix Actions type definition
c607f93 
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message.

Closes #407

refactor(types): remove indexed signature for publish

Remove redundant indexed signature from publish message parameters type definition.

Closes #413

refactor(types): add serializable objects to `Payload` type

Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods.

Closes #412

refactor(types): aggregate generated types definitions

Aggregate multiple types definitions into single type definition type with proper type names and namespaces.

Closes #405 #409 #410

refactor(types): add missing Subscribe Event Engine types

Add Subscribe Event Engine and Event Listener types to the bundled types definition file.

Closes #377
@parfeon parfeon mentioned this issue Oct 30, 2024
Merged
parfeon added a commit that referenced this issue Oct 31, 2024
@parfeon
Fix types definition issues (#417)
66520c2 
fix(types): fix `Actions` type definition

Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message.

Closes #407

refactor(types): remove indexed signature for publish

Remove redundant indexed signature from publish message parameters type definition.

Closes #413

refactor(types): add serializable objects to `Payload` type

Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods.

Closes #412

refactor(types): aggregate generated types definitions

Aggregate multiple types definitions into single type definition type with proper type names and namespaces.

Closes #405 #409 #410

refactor(types): add missing Subscribe Event Engine types

Add Subscribe Event Engine and Event Listener types to the bundled types definition file.

Closes #377
@parfeon
Copy link
Contributor

parfeon commented Oct 31, 2024

@yo1dog this issue is addressed in v8.2.10

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@parfeon parfeon

Labels
priority: medium This PR should be reviewed after all high priority PRs. status: in progress This issue is being worked on. type: fix This PR contains fixes to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix types definition issues pubnub/javascript
2 participants
@parfeon @yo1dog