Skip to content

Avoid popup on macOS when developer tools aren't installed #367

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 26, 2018

Conversation

girardc79
Copy link

On macOS ("Darwin"), check that the xcode-select path exists before attempting to run svn. This avoids the popup dialog that is produced when the developer tools are not yet installed.

@david22swan
Copy link
Member

@girardc79 In a situation such as this wouldn't it be best that a message is passed back, rather than just not running.

@david22swan
Copy link
Member

nvm

@david22swan david22swan merged commit bebae04 into puppetlabs:master Feb 26, 2018
@girardc79 girardc79 deleted the avoid_mac_svn_popup branch March 2, 2018 20:46
@pmcmaw pmcmaw added the bugfix label Sep 20, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants