Skip to content

Avoid popup on macOS when developer tools aren't installed #367

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Avoid popup on macOS when developer tools aren't installed #367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01871cf
Add guard for macOS to avoid popup dialog when developer tools aren't…
Nov 21, 2017
926b312
Fix RuboCop violations.
Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/facter/vcsrepo_svn_ver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
Facter.add(:vcsrepo_svn_ver) do
setcode do
begin
version = Facter::Core::Execution.execute('svn --version --quiet')
if Gem::Version.new(version) > Gem::Version.new('0.0.1')
version
else
if Facter.value(:operatingsystem) == 'Darwin' && !File.directory?(Facter::Core::Execution.execute('xcode-select -p'))
''
else
version = Facter::Core::Execution.execute('svn --version --quiet')
if Gem::Version.new(version) > Gem::Version.new('0.0.1')
version
else
''
end
end
rescue StandardError
''
Expand Down