Skip to content

Proposal for better error message about in-place operation #3976

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2020
Merged

Proposal for better error message about in-place operation #3976

merged 4 commits into from
Jun 24, 2020

Conversation

mancellin
Copy link
Contributor

Trying to make error message slightly more informative when the user might expect automatic alignment with in-place operation.

shoyer
shoyer reviewed Apr 17, 2020
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you!

@mancellin
Copy link
Contributor Author

mancellin commented Apr 17, 2020 •
edited
Loading

Thank you for your comments @shoyer
I agree with all of them and have updated the code.

@dcherian dcherian mentioned this pull request May 5, 2020
Closed
23 tasks
@dcherian
Copy link
Contributor

Thanks @mancellin

@dcherian dcherian merged commit fb5fe79 into pydata:master Jun 24, 2020
dcherian added a commit to raphaeldussin/xarray that referenced this pull request Jul 1, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix_facecolor_plot
b1c15ad 
* upstream/master: (21 commits)
  fix typo in error message in plot.py (pydata#4188)
  Support multiple dimensions in DataArray.argmin() and DataArray.argmax() methods (pydata#3936)
  Show data by default in HTML repr for DataArray (pydata#4182)
  Blackdoc (pydata#4177)
  Add CONTRIBUTING.md for the benefit of GitHub
  Correct dask handling for 1D idxmax/min on ND data (pydata#4135)
  use assert_allclose in the aggregation-with-units tests (pydata#4174)
  Remove old auto combine (pydata#3926)
  Fix 4009 (pydata#4173)
  Limit length of dataarray reprs (pydata#3905)
  Remove <pre> from nested HTML repr (pydata#4171)
  Proposal for better error message about in-place operation (pydata#3976)
  use builtin python types instead of the numpy alias (pydata#4170)
  Revise pull request template (pydata#4039)
  pint support for Dataset (pydata#3975)
  drop eccodes in docs (pydata#4162)
  Update issue templates inspired/based on dask (pydata#4154)
  Fix failing upstream-dev build & remove docs build (pydata#4160)
  Improve typehints of xr.Dataset.__getitem__ (pydata#4144)
  provide a error summary for assert_allclose (pydata#3847)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shoyer shoyer shoyer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-place addition of arrays with the same coords but in a different order
3 participants
@mancellin @dcherian @shoyer