Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Primerdesignbug #300

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Primerdesignbug #300

merged 4 commits into from
Oct 10, 2024

Conversation

manulera
Copy link
Collaborator

@manulera manulera commented Oct 8, 2024

Hi @BjornFJohansson I have been fixing the history of dev_bjorn to be properly grafted into master. I have also fixed the history of the primerdesignbug branch and create this one that contains the same code, but has the right commit history. You can keep working on this one, or merge if the fix is finished.

Best,
Manu

@manulera manulera changed the base branch from master to dev_bjorn October 8, 2024 11:13
@manulera
Copy link
Collaborator Author

manulera commented Oct 8, 2024

I added an extra commit to re-run the notebook, since the output was wrong due to the bug from #279 (now fixed).

I actually have included a similar example that is now in the README, with a matching notebook at docs/notebooks/readme_example.ipynb

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (f063c40) to head (c11bee7).
Report is 6 commits behind head on dev_bjorn.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           dev_bjorn     #300   +/-   ##
==========================================
  Coverage      93.60%   93.60%           
==========================================
  Files             40       40           
  Lines           3922     3922           
  Branches         588      588           
==========================================
  Hits            3671     3671           
  Misses           199      199           
  Partials          52       52           
Files with missing lines Coverage Δ
src/pydna/design.py 97.51% <100.00%> (ø)

@BjornFJohansson
Copy link
Collaborator

Thanks! This seems to be ok. The example.ipynb is now correct.

@BjornFJohansson BjornFJohansson merged commit 9d112d7 into dev_bjorn Oct 10, 2024
34 checks passed
@BjornFJohansson BjornFJohansson deleted the primerdesignbug_2 branch October 10, 2024 11:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants