Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Skip pure wheels in auditwheel #7

Closed
letmaik opened this issue May 24, 2016 · 5 comments · Fixed by #22
Closed

Skip pure wheels in auditwheel #7

letmaik opened this issue May 24, 2016 · 5 comments · Fixed by #22

Comments

@letmaik
Copy link

letmaik commented May 24, 2016

Currently the demo doesn't have any pure python dependencies. But if you have any, then those go into the wheelhouse/ folder as well. If you then simply loop with for whl in 'wheelhouse/*.whl' to call auditwheel it will fail for the pure Python packages with "Cannot add platforms to pure wheel". Also, even for binary wheels, I don't want to process any of my dependencies, just my own package, since this is what I would upload to PyPI later, directly from Travis CI. My feeling is that a bit of logic is missing in the demo.

My request: Can the demo be extended to include a small pure Python dependency?

@njsmith
Copy link
Member

njsmith commented May 24, 2016

If you only want it to run on your own package, maybe it's as simple as using for whl in wheelhouse/rawpy-*.whl?

If that works then maybe you can submit a PR to make the example clearer?

@letmaik
Copy link
Author

letmaik commented May 24, 2016

I had the same thought and tried it, and as expected it works. Not sure
when I could get around to do a PR. I'll see.

@pombredanne
Copy link

See pypa/auditwheel#47 and see the poor man quick and hacky way here: https://github.com/pombreda/thirdparty-manylinux/blob/3c35a8fa5eee12dec76993a90632e22cc6dbbe01/travis/build-wheels.sh#L24 (not proud of it, I just wanted to get something working quick)

crizCraig added a commit to crizCraig/python-manylinux-demo that referenced this issue Aug 4, 2018
@marcelm
Copy link

marcelm commented Nov 16, 2019

Would it be a solution to add --no-deps to the pip wheel invocation?

@lkollar
Copy link
Contributor

lkollar commented May 10, 2020

Auditwheel now returns a non-zero exit value on non-platform wheels. #22 updates the build script to skip such wheels.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants