Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use auditwheel show to detect platform wheels #23

Merged
merged 1 commit into from
May 11, 2020

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented May 11, 2020

To avoid masking errors when skipping non-platform wheels, use
auditwheel show first to detect platform wheels.

To avoid masking errors when skipping non-platform wheels, use
`auditwheel show` first to detect platform wheels.
@lkollar lkollar self-assigned this May 11, 2020
@marcelm
Copy link

marcelm commented May 11, 2020

I think the actual problem is that pip wheel also creates wheels for dependencies, not only for the target. The problem then arises when auditwheel repair tries to repair a dependency.

As I mentioned in #7 (comment), that could be solved by just running pip wheel with --no-deps. I’ve done this in my own repos and it has been working well.

@marcelm
Copy link

marcelm commented May 11, 2020

Either way, #17 can then also be closed.

@lkollar
Copy link
Contributor Author

lkollar commented May 11, 2020

@marcelm I agree that --no-deps should be added but I think these are both useful as skipping non-platform wheels makes it easy to use this script on pure-Python projects as well. I will submit another PR to add --no-deps as well.

@marcelm
Copy link

marcelm commented May 11, 2020

Ok, I think I just wouldn’t have expected this script to be used in pure Python projects where a regular pip wheel would be sufficient.

@lkollar lkollar merged commit 8951a77 into pypa:master May 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants