Skip to content

gh-104057: Fix direct invocation of test_support #104069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

gh-104057: Fix direct invocation of test_support #104069

merged 1 commit into from
May 11, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 1, 2023 •
edited by bedevere-bot
Loading 

./python Lib/test/test_support.py
Running Debug|x64 interpreter...
.....................s.F......s.........s...
======================================================================
FAIL: test_ignored_deprecations_are_silent (__main__.TestSupport.test_ignored_deprecations_are_silent)
Test support.ignore_deprecations_from() silences warnings
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_support.py", line 52, in test_ignored_deprecations_are_silent       
    self.assertEqual(len(messages), 0, messages)
AssertionError: 1 != 0 : ['You should NOT be seeing this.']

----------------------------------------------------------------------
Ran 44 tests in 8.697s

FAILED (failures=1, skipped=3)

However, there's an another bug with test_make_bad_fd (only on Windows) but it's not related.

@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 1, 2023
@AlexWaygood AlexWaygood changed the title gh-104057: Fix direct invocatoin of test_support gh-104057: Fix direct invocation of test_support May 1, 2023
@furkanonder
Copy link
Contributor

LGTM.

@zware zware merged commit 27419a7 into python:main May 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
fb47955 
* main:
  pythongh-104057: Fix direct invocation of test_support (pythonGH-104069)
  pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270)
  pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)
@Eclips4 Eclips4 deleted the fix_test_support branch May 12, 2023 07:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@furkanonder furkanonder furkanonder approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eclips4 @furkanonder @zware @bedevere-bot @AlexWaygood