Skip to content

gh-101819: Fix inverted debug preprocessor check in winconsoleio.c #104388

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2023
Merged

gh-101819: Fix inverted debug preprocessor check in winconsoleio.c #104388

merged 1 commit into from
May 11, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 11, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland requested a review from vstinner May 11, 2023 12:30
@bedevere-bot bedevere-bot mentioned this pull request May 11, 2023
Closed
vstinner
vstinner approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland enabled auto-merge (squash) May 11, 2023 12:58
@erlend-aasland erlend-aasland merged commit ddc0e70 into python:main May 11, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon
fb47955 
* main:
  pythongh-104057: Fix direct invocation of test_support (pythonGH-104069)
  pythongh-87729: improve hit rate of LOAD_SUPER_ATTR specialization (python#104270)
  pythongh-101819: Fix inverted debug preprocessor check in winconsoleio.c (python#104388)
@erlend-aasland erlend-aasland deleted the isolate-io/address-reviews branch May 21, 2023 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @vstinner @bedevere-bot