feat: Add preliminary support for freezing tensors in Dynamo #2128

gs-olive · 2023-07-21T04:35:01Z

Description

Adds support for tensor freezing in Dynamo, updating necessary utilities, tests, and converters to handle the functionality

Fixes #2124
Dependent on: #2252, #2253

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ + ] I have added tests to verify my fix or my feature
- CI verification on key models
- Existing tests validate the compiler
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

fix: Refactor tensor freezing in Dynamo Key op fixes for failing tests

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py

gs-olive added the Story: Export/Compile Unification Issues relating to unification of Dynamo compile/export paths label Jul 21, 2023

gs-olive self-assigned this Jul 21, 2023

facebook-github-bot added the cla signed label Jul 21, 2023

github-actions bot added the component: api [Python] Issues re: Python API label Jul 21, 2023

github-actions bot requested a review from narendasan July 21, 2023 04:35

github-actions bot approved these changes Jul 21, 2023

View reviewed changes

gs-olive removed the request for review from narendasan July 21, 2023 04:35

github-actions bot approved these changes Jul 21, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 8d32f9c to a208df5 Compare July 21, 2023 04:35

github-actions bot approved these changes Jul 21, 2023

View reviewed changes

gs-olive added the WIP Work is in progress, pull request should not be merged yet label Jul 21, 2023

github-actions bot requested a review from narendasan July 21, 2023 17:45

gs-olive mentioned this pull request Aug 1, 2023

✨[Improvement] Unified + Selective Decomposition System for Dynamo #2160

Closed

gs-olive force-pushed the dynamo_tensor_freeze branch from a208df5 to 88ba994 Compare August 5, 2023 00:16

github-actions bot added component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: torch_compile labels Aug 5, 2023

github-actions bot approved these changes Aug 5, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 88ba994 to 78f000f Compare August 5, 2023 00:17

github-actions bot approved these changes Aug 5, 2023

View reviewed changes

github-actions bot added component: converters Issues re: Specific op converters component: fx labels Aug 5, 2023

github-actions bot approved these changes Aug 5, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 5c4e9ac to 9943e6c Compare August 7, 2023 21:28

github-actions bot approved these changes Aug 7, 2023

View reviewed changes

github-actions bot approved these changes Sep 9, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 890ba72 to 1806a57 Compare September 9, 2023 00:46

github-actions bot approved these changes Sep 9, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 1806a57 to dfc4899 Compare September 9, 2023 01:03

gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Sep 9, 2023

gs-olive marked this pull request as ready for review September 9, 2023 01:03

github-actions bot approved these changes Sep 9, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from dfc4899 to 9cde6af Compare September 9, 2023 06:27

github-actions bot approved these changes Sep 9, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 9cde6af to 0005a31 Compare September 9, 2023 06:36

github-actions bot approved these changes Sep 9, 2023

View reviewed changes

gs-olive added 5 commits September 11, 2023 11:02

feat: Add preliminary support for freezing tensors in Dynamo

399f929

fix: Refactor tensor freezing in Dynamo Key op fixes for failing tests

fix: Add constant folding utility to freezing

4b44ff2

fix: Move tracer code into try/except

a94a075

Custom implementation of AOT for compile

4e308f1

Move fixes into Dynamo directory

95d3f98

gs-olive force-pushed the dynamo_tensor_freeze branch from 0005a31 to 95d3f98 Compare September 11, 2023 18:02

github-actions bot approved these changes Sep 11, 2023

View reviewed changes

peri044 approved these changes Sep 11, 2023

View reviewed changes

py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py Show resolved Hide resolved

gs-olive merged commit 100191b into main Sep 12, 2023

gs-olive deleted the dynamo_tensor_freeze branch September 12, 2023 01:20

feat: Add preliminary support for freezing tensors in Dynamo #2128

feat: Add preliminary support for freezing tensors in Dynamo #2128

Uh oh!

Conversation

gs-olive commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

gs-olive commented Jul 21, 2023 •

edited

Loading