Skip to content

feat: support linear (fully connected layer) dynamo converter #2253

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2023
Merged

feat: support linear (fully connected layer) dynamo converter #2253

merged 2 commits into from
Sep 9, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support linear (fully connected layer) dynamo converter.

Fixes #2251

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 21, 2023
@github-actions github-actions bot requested a review from narendasan August 21, 2023 23:48
narendasan
narendasan requested changes Aug 23, 2023
View reviewed changes
@gs-olive gs-olive mentioned this pull request Aug 30, 2023
Merged
gs-olive
gs-olive reviewed Aug 30, 2023
View reviewed changes
@zewenli98 zewenli98 force-pushed the fully_connected_dynamo_converter branch from 50734d3 to 67d28b4 Compare August 30, 2023 23:46
@zewenli98 zewenli98 mentioned this pull request Aug 30, 2023
Merged
7 tasks
@zewenli98 zewenli98 force-pushed the fully_connected_dynamo_converter branch from 67d28b4 to 00d89fc Compare September 1, 2023 01:44
@zewenli98
Copy link
Collaborator Author

zewenli98 commented Sep 1, 2023 •
edited
Loading

This PR relies on #2263 aten.add

@gs-olive gs-olive mentioned this pull request Sep 6, 2023
Closed
@gs-olive
Copy link
Collaborator

gs-olive commented Sep 8, 2023

@zewenli98 - #2263 has been merged - could you rebase this PR onto the latest main?

@zewenli98 zewenli98 force-pushed the fully_connected_dynamo_converter branch from ff18dcd to d0f0012 Compare September 8, 2023 22:22
gs-olive
gs-olive reviewed Sep 8, 2023
View reviewed changes
gs-olive
gs-olive approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gs-olive gs-olive merged commit 8c92918 into pytorch:main Sep 9, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narendasan narendasan narendasan requested changes

@gs-olive gs-olive gs-olive approved these changes

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose IFullyConnectedLayer in dynamo.conversion.impl
4 participants
@zewenli98 @gs-olive @narendasan @facebook-github-bot