Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

code smells: make more readonly #1740

Merged
merged 8 commits into from
Oct 4, 2024
Merged

code smells: make more readonly #1740

merged 8 commits into from
Oct 4, 2024

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Oct 2, 2024

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@qdraw qdraw changed the title make more readonly code smells: make more readonly Oct 2, 2024
@qdraw qdraw merged commit 1eb2e6c into master Oct 4, 2024
19 of 21 checks passed
@qdraw qdraw deleted the feature/202410_code_smells_2 branch October 4, 2024 07:44
Copy link

sonarqubecloud bot commented Oct 4, 2024

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant