-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use tutorial, round 2 #645
Conversation
Looks like builds are failing because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I made a few comments.
There's a test failing on AppVeyor and Travis. You probably need to use the same mocking strategy we use elsewhere to get around the need for learnr to be installed. usethis/tests/testthat/test-use-roxygen.R Lines 18 to 29 in b0df5f1
|
@garrettgman If you took this for a spin, that would be great. It basically looks good to me, so I plan to merge soon, after we wrap up the loose ends. |
Can you also please add a bullet to NEWS? It should briefly describe the change and end with |
Good grief it took me a while to get the test and mocking sorted -- probably just as well that I was the one to suffer through that. Thanks! |
* Add use_rcpp_armadillo() and use_rcpp_eigen(). (closes #421). Note: This is the second coming of PR #601 based on feedback from @jennybc. She requested the design pattern in #645 for testing a package without needing to add it to the Suggests field. This is important as RcppArmadillo has a hard dependency on R >= 3.2. * usethis itself doesn't need RcppEigen in Suggests * Style
You caught me at a busy time, but thanks for helping out with the rest of the edits! Appreciate your support on this (thanks for figuring out the mocking). It's exciting to see |
Closes #314 use_tutorial()
Making this PR properly from a branch instead of master of my forked repo, incorporating code review edits in #584
Merge me instead of #584! 😄