Add use_rcpp_armadillo() and use_rcpp_eigen(). (closes #421). #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I made a few small changes, so please speak up if you take issue with them. |
|
@jennybc thanks! 👍 on all changes. I take it that for the stylization this was just a call to |
Yep. |
|
Well, I think I removed the full stop in the roxygen title by hand. https://style.tidyverse.org/documentation.html#title-and-description |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second coming of PR #601 based on feedback from @jennybc. She requested the unit test design pattern found in PR #645 for testing a package without needing to add it to the Suggests field. This is important as
RcppArmadillohas a hard dependency forR >= 3.2.*while the state ofusethisallows forR 3.1.*.