Attempt to prevent responses with Transfer-Encoding: chunked #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's probably a bad idea to implement Transfer-Encoding chunked inside an application, since only HTTP/1.1 supports it. However, some applications and frameworks still do so. However, they should only do so if they receive an HTTP/1.1 request, it's certainly a bug in the application to use Transfer-Encoding: chunked for HTTP/1.0 requests. Set SERVER_PROTOCOL and HTTP_VERSION to HTTP/1.0 in requests to try to avoid responses with Transfer-Encoding: chunked. While here, avoid 4 unnecessary hash allocations by using either Hash#merge! instead of #merge, or using Hash#[]= instead of allocating a hash to pass to Hash#update.
This currently still runs rubocop, but rubocop failure does not cause workflow failure and won't block merging.
ioquatix
approved these changes
May 2, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably a bad idea to implement Transfer-Encoding
chunked inside an application, since only HTTP/1.1 supports
it. However, some applications and frameworks still do so.
However, they should only do so if they receive an HTTP/1.1
request, it's certainly a bug in the application to use
Transfer-Encoding: chunked for HTTP/1.0 requests.
Set SERVER_PROTOCOL and HTTP_VERSION to HTTP/1.0 in requests
to try to avoid responses with Transfer-Encoding: chunked.
While here, avoid 4 unnecessary hash allocations by using
either Hash#merge! instead of #merge, or using Hash#[]=
instead of allocating a hash to pass to Hash#update.