Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Attempt to prevent responses with Transfer-Encoding: chunked #288

Merged
merged 2 commits into from
May 2, 2022
Merged

Attempt to prevent responses with Transfer-Encoding: chunked #288

merged 2 commits into from
May 2, 2022

Commits on May 2, 2022

  1. Attempt to prevent responses with Transfer-Encoding: chunked 

    It's probably a bad idea to implement Transfer-Encoding
chunked inside an application, since only HTTP/1.1 supports
it.  However, some applications and frameworks still do so.
However, they should only do so if they receive an HTTP/1.1
request, it's certainly a bug in the application to use
Transfer-Encoding: chunked for HTTP/1.0 requests.

Set SERVER_PROTOCOL and HTTP_VERSION to HTTP/1.0 in requests
to try to avoid responses with Transfer-Encoding: chunked.

While here, avoid 4 unnecessary hash allocations by using
either Hash#merge! instead of #merge, or using Hash#[]=
instead of allocating a hash to pass to Hash#update.
    @jeremyevans
    jeremyevans committed May 2, 2022
    Configuration menu
    Copy the full SHA
    8990d2e View commit details
    Browse the repository at this point in the history

  2. Don't consider lint failure as workflow failure 

    This currently still runs rubocop, but rubocop failure does not
cause workflow failure and won't block merging.
    @jeremyevans
    jeremyevans committed May 2, 2022
    Configuration menu
    Copy the full SHA
    ac7eeb3 View commit details
    Browse the repository at this point in the history