-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Avoid printing dot when copyright holder already ends with dot #666
Conversation
I would rather we remove the second added period and leave it up to the author how the copyright is punctuated. |
@Blendify thank you for the reply. Do you like this solution better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this plan better. +1
e.g. My Company, Inc.
Alright @Blendify, I've rebased the PR. |
Ok, looking for one more quick approval. |
I'd like it even better if the user could customize the entire copyright message (including copyright sign), but that is more the responsibility of Sphinx. LGTM |
When you set
copyright = "My Company, Inc."
inconf.py
for your documentation and generate html from it, the copyright is rendered like this:Which is bad, we ideally want to have only one dot at the end.
It can't be workarounded by setting
copyright = "My Company, Inc"
, because then man pages get rendered wrong, e.g.Therefore I am proposing this pull request. It is quite hard to fix it properly because it needs to be done per-theme and therefore it can bring some inconsistencies. If there is a better way to fix it, please let me know.