Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add missing dot after copyright. #898

Closed
wants to merge 1 commit into from
Closed

Add missing dot after copyright. #898

wants to merge 1 commit into from

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Apr 8, 2020

The following stuff each has a dot at the end.

@Blendify Blendify self-requested a review April 9, 2020 03:14
@Blendify
Copy link
Member

Blendify commented Apr 9, 2020

This is intentional so developers have full control of the text.

@mgeier
Copy link
Contributor Author

mgeier commented Apr 9, 2020

It's still a breaking change from the basic theme:

https://github.com/sphinx-doc/sphinx/blob/80d9728101ab349050a708261da623a306f09f85/sphinx/themes/basic/layout.html#L199-L205

@stsewd
Copy link
Member

stsewd commented Oct 7, 2020

Looks this is superseded by #933, discussion about the final dot #666

@stsewd
Copy link
Member

stsewd commented Dec 3, 2020

Closed by #933

@stsewd stsewd closed this Dec 3, 2020
@mgeier mgeier deleted the copyright-dot branch December 4, 2020 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Blendify Blendify Awaiting requested review from Blendify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgeier @Blendify @stsewd