Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Excluding Pods files by default (fix #6) #35

Closed
wants to merge 1 commit into from

Conversation

GlaucoNeves
Copy link

A start point to make SwiftLint configurable to chose which folders to scan.

@jpsim
Copy link
Collaborator

jpsim commented May 26, 2015

Thanks for the PR, but I'd really rather have the ability to exclude folders explicitly rather than have some hardcoded exceptions for Pods/ and Carthage/.

@GlaucoNeves
Copy link
Author

Agreed. Do you already have an idea of how this should be configured? Maybe passed as parameters when invoked the SwiftLint? I can take a look in that.

@jpsim
Copy link
Collaborator

jpsim commented May 26, 2015

Yes, a Commandant parameter would be appropriate for this I think.

@eneko
Copy link

eneko commented Aug 20, 2015

Any updates on this? I think this belongs to the .swiftlint.yml configuration file, is there any PR for that yet?

@jpsim
Copy link
Collaborator

jpsim commented Aug 23, 2015

Any updates on this? I think this belongs to the .swiftlint.yml configuration file, is there any PR for that yet?

not yet!

@jakecraige
Copy link
Contributor

Since the config #99 has been merged, should this be closed?

@jpsim
Copy link
Collaborator

jpsim commented Aug 28, 2015

Since the config #99 has been merged, should this be closed?

Yes, I'd say so. Pods/ and Carthage/ directories still aren't excluded by default, but it's now trivial to do by adding those directories to a .swiftlint.yml

@jpsim jpsim closed this Aug 28, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants