Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Configure SwiftLint via a YAML file #99

Merged
merged 3 commits into from
Aug 28, 2015
Merged

Configure SwiftLint via a YAML file #99

merged 3 commits into from
Aug 28, 2015

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Aug 24, 2015

Fixes #1 and #3.

@jpsim
Copy link
Collaborator Author

jpsim commented Aug 25, 2015

@keith I assume this would be useful for you, I'd love if you could share your thoughts on the implementation.


public init?(yaml: String) {
guard let yamlConfig = Yaml.load(yaml).value else {
return nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this print some error about an invalid config?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see this error below

@keith
Copy link
Collaborator

keith commented Aug 25, 2015

Awesome! This looks great! 👍

jpsim added a commit that referenced this pull request Aug 28, 2015
Configure SwiftLint via a YAML file
@jpsim jpsim merged commit 20d9db9 into swift-2.0 Aug 28, 2015
@jpsim jpsim deleted the yaml branch August 28, 2015 02:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants