Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

added promoted property test for annotation to attribute rule #425

Merged
merged 3 commits into from
Jul 12, 2021
Merged

added promoted property test for annotation to attribute rule #425

merged 3 commits into from
Jul 12, 2021

Conversation

calvera
Copy link
Contributor

@calvera calvera commented Jul 11, 2021

@calvera calvera mentioned this pull request Jul 11, 2021
Closed
@TomasVotruba
Copy link
Member

Thanks for the PR 👍

It seems the Param node is missing in the nodes to process:

rector-src/rules/Php80/Rector/Class_/AnnotationToAttributeRector.php

Line 111 in fb9ad83

public function getNodeTypes(): array

Could you add it there?

@calvera
Copy link
Contributor Author

calvera commented Jul 11, 2021

it works after the fix (but the generated code is not formatted nicely)

@samsonasik
Copy link
Member

Formatting seems needs to by coding standard.

@TomasVotruba TomasVotruba merged commit d08a87f into rectorphp:main Jul 12, 2021
@TomasVotruba
Copy link
Member

Thank you @calvera for improvement 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvera @TomasVotruba @samsonasik