Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added promoted property test for annotation to attribute rule #425

Merged
merged 3 commits into from
Jul 12, 2021
Merged

added promoted property test for annotation to attribute rule #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bfdb1e
added promoted property test for annotation to attribute rule
calvera Jul 11, 2021
03f6f5a
fix promoted property annotation to attribute rule
calvera Jul 11, 2021
ab24593
fix promoted property annotation to attribute rule - phpdocs fix
calvera Jul 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...s-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/promoted_property.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php

namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;

use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;

final class PromotedProperty
{
public function __construct(
/**
* @GenericAnnotation
*/
private string $property,
) {}
}

?>
-----
<?php

namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture;

use Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation;

final class PromotedProperty
{
public function __construct(
#[\Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Source\GenericAnnotation] private string $property,
) {}
}

?>
4 changes: 3 additions & 1 deletion rules/Php80/Rector/Class_/AnnotationToAttributeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use PhpParser\Node\AttributeGroup;
use PhpParser\Node\Expr\ArrowFunction;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
Expand Down Expand Up @@ -113,6 +114,7 @@ public function getNodeTypes(): array
return [
Class_::class,
Property::class,
Param::class,
ClassMethod::class,
Function_::class,
Closure::class,
Expand All @@ -121,7 +123,7 @@ public function getNodeTypes(): array
}

/**
* @param Class_|Property|ClassMethod|Function_|Closure|ArrowFunction $node
* @param Class_|Property|Param|ClassMethod|Function_|Closure|ArrowFunction $node
*/
public function refactor(Node $node): ?Node
{
Expand Down