Skip to content

Support JSON.MSET Command #2513

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 7 commits into from
Closed

Support JSON.MSET Command #2513

wants to merge 7 commits into from

Conversation

shacharPash
Copy link
Contributor

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Closes #2499

@shacharPash shacharPash changed the title Node/support json.mset Support JSON.MSET Command May 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (67d9c3c) 95.67% compared to head (7026a27) 95.66%.

❗ Current head 7026a27 differs from pull request most recent head e4fa732. Consider uploading reports for the commit e4fa732 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   95.67%   95.66%   -0.01%     
==========================================
  Files         455      454       -1     
  Lines        4552     4549       -3     
  Branches      522      523       +1     
==========================================
- Hits         4355     4352       -3     
  Misses        128      128              
  Partials       69       69              
Impacted Files Coverage Δ
packages/client/lib/commands/XINFO_CONSUMERS.ts 100.00% <ø> (ø)
packages/search/lib/commands/SEARCH.ts 82.60% <ø> (ø)
packages/search/lib/commands/AGGREGATE.ts 100.00% <100.00%> (ø)
packages/search/lib/commands/CURSOR_READ.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from leibale May 17, 2023 13:45
Copy link
Contributor

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I left some comments..

@shacharPash shacharPash requested a review from leibale May 18, 2023 10:38
@shacharPash shacharPash requested a review from leibale May 21, 2023 14:09
@shacharPash shacharPash requested a review from leibale May 21, 2023 14:26
@leibale
Copy link
Contributor

leibale commented Sep 18, 2023

Duplicate of #2605

@leibale leibale marked this as a duplicate of #2605 Sep 18, 2023
@leibale leibale closed this Sep 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON.MSET
3 participants