Add support for JSON.MSET
#2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSET command added. Requires all keys to have the same JSON Path, which might fit most use cases, but is a limitation. Optionally we could make the path an array as well to support all use cases.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
- Coverage 95.66% 95.65% -0.01%
==========================================
Files 456 455 -1
Lines 4563 4555 -8
Branches 526 525 -1
==========================================
- Hits 4365 4357 -8
Misses 127 127
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Removed unused RedisCommandArguments
|
@rowantrollope |
|
Thank you!
Hopefully next time you won’t have to rewrite *all* my code …;)
Rowan
Sent via Superhuman iOS ( ***@***.*** )
…On Tue, Sep 19 2023 at 3:00 PM, Leibale Eidelman < ***@***.*** > wrote:
@rowantrollope ( https://github.com/rowantrollope ) ***@***.*** / @***@***.***
is on npm 🎉
—
Reply to this email directly, view it on GitHub (
#2605 (comment) ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ACXKL5O6YTG2ZKD5EJFK5SLX3IIZLANCNFSM6AAAAAA4DJQ5ZI
).
You are receiving this because you were mentioned. Message ID: <redis/node-redis/pull/2605/c1726600099
@ github. com>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSET command added. Requires all keys to have the same JSON Path, which might fit most use cases, but is a limitation. Optionally we could make the path an array as well to support all use cases.
Description
Adding support for JSON.MSET - this implementation uses a single path, which may be limiting. If desired we could make this an array as well.
Checklist
npm testpass with this change (including linting)?