Skip to content

Fixing the package to include commands #1649

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Fixing the package to include commands #1649

merged 3 commits into from
Oct 26, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Oct 26, 2021

Fixes #1645

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #1649 (9da4416) into master (2b0a1e7) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

❗ Current head 9da4416 differs from pull request most recent head c2b29e4. Consider uploading reports for the commit c2b29e4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1649      +/-   ##
==========================================
- Coverage   89.01%   88.99%   -0.02%     
==========================================
  Files          52       52              
  Lines       10112    10113       +1     
==========================================
- Hits         9001     9000       -1     
- Misses       1111     1113       +2     
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
redis/__init__.py 100.00% <100.00%> (ø)
tests/test_search.py 98.15% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0a1e7...c2b29e4. Read the comment docs.

@chayim chayim changed the title Fixing the package to include commands. Fixing the package to include commands Oct 26, 2021
@chayim chayim merged commit 866ac00 into master Oct 26, 2021
@chayim chayim deleted the ck-fix-packaging branch October 26, 2021 11:13
@akx
Copy link
Contributor

akx commented Sep 19, 2022

This PR effectively just reverted the (good) changes in #1316 when the correct change would have been to add redis.commands (and other packages, or to use packages = find:) to setup.cfg...

akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
Refs redis#1316
Refs redis#1649

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
Refs redis#1316
Refs redis#1649

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
Refs redis#1316
Refs redis#1649

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

x
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 5, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 15, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Jun 12, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 25, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
petyaslavova pushed a commit that referenced this pull request Feb 25, 2025
* Switch to PEP 517 packaging using hatchling

Refs #1316
Refs #1649
Remake of #2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

* Use a single source of truth for version info

* Uninstall redis wheel installed as redis-entraid dep

* Add build as dev_requirement

* Get rid of requirements.txt

* Get rid of setuptools and wheel deps

* Move pytest configuration to pyproject.toml

* Retain tests and dev_requirements.txt in sdist

---------

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis.commands module missing in pypi release 4.0.0b2
3 participants