Skip to content

Switch to PEP 517 packaging using hatchling #2388

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 19, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
    • not applicable
  • Was the change added to CHANGES file?
    • not yet

Description of change

This PR shifts redis-py from legacy setup.py packaging to PEP 517 compliant packaging using hatchling from PyPA.

Essentially, this does what was discussed in #1658 but with the increasingly standard hatchling tool instead of poetry's idiosyncracies.

Refs #1316 (which initially did this, with tools from that age)
Refs #1649 (which reverted that for no good reason)

I wasn't able to test all of these changes yet, but python -m build does create a working wheel with all modules included.

@akx akx force-pushed the pep517 branch 2 times, most recently from af128aa to 46965bb Compare September 19, 2022 12:56
@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Sep 19, 2022
@akx akx force-pushed the pep517 branch 2 times, most recently from e8e7837 to ab8e9a7 Compare September 21, 2022 12:52
Refs redis#1316
Refs redis#1649

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
@chayim
Copy link
Contributor

chayim commented Sep 28, 2022

With no clear winner in the packaging space (yet) - and the ongoing flux, I don't see redis-py moving from setup.py currently. As this changes, it too should change. But hatch, is yet another attempt at something, and we'll watch it as it gains steam.

@chayim chayim closed this Sep 28, 2022
@ofek
Copy link
Contributor

ofek commented Sep 28, 2022

I don't see redis-py moving from setup.py currently.

Hey! Do you have some heuristic in mind, so the next person doesn't waste their time?

the ongoing flux

I don't see much of that. The pyproject.toml way is for sure the standard, is documented as such, and the execution of setup.py files is deprecated.

@ischaojie
Copy link

sadly to see this :(, pyproject.toml is already the de facto standard.

akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

x
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Sep 5, 2023
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 15, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Jun 12, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
akx added a commit to akx/redis-py that referenced this pull request Feb 25, 2025
Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
petyaslavova pushed a commit that referenced this pull request Feb 25, 2025
* Switch to PEP 517 packaging using hatchling

Refs #1316
Refs #1649
Remake of #2388

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

* Use a single source of truth for version info

* Uninstall redis wheel installed as redis-entraid dep

* Add build as dev_requirement

* Get rid of requirements.txt

* Get rid of setuptools and wheel deps

* Move pytest configuration to pyproject.toml

* Retain tests and dev_requirements.txt in sdist

---------

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants