Dont log single fetch thrown redirect response stubs via handleError #9369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d516612 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
May 3, 2024
| @@ -437,6 +427,17 @@ async function handleDocumentRequest( | |||
| headers = getDocumentHeaders(build, context); | |||
| } | |||
|
|
|||
| // Sanitize errors outside of development environments | |||
| if (context.errors) { | |||
There was a problem hiding this comment.
Swapped the order of these to colocate the redirect handling
brophdawg11
commented
May 3, 2024
| if (context.errors) { | ||
| Object.values(context.errors).forEach((err) => { | ||
| // @ts-expect-error `err.error` is "private" from users but intended for internal use | ||
| if ((!isRouteErrorResponse(err) || err.error) && !isResponseStub(err)) { |
There was a problem hiding this comment.
Don't log response stubs either
jacob-ebey
approved these changes
May 6, 2024
github-actions
bot
added
the
awaiting release
This was referenced May 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9358