Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle predictors with deferred annotations #1772

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

mattt
Copy link
Contributor

@mattt mattt commented Jun 26, 2024

Resolves #600

This PR starts with a failing test case, and then applies the changes from #601.

@mattt mattt force-pushed the mattt/deferred-annotations branch from 16d2e18 to 05768ba Compare June 26, 2024 13:16
Co-authored-by: Elazar Gershuni <elazarg@gmail.com>
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
@mattt mattt force-pushed the mattt/deferred-annotations branch from 05768ba to ac85af8 Compare June 26, 2024 13:37
@mattt mattt requested review from bfirsh and a team June 26, 2024 19:43
@mattt mattt merged commit 05900a7 into main Jun 28, 2024
12 checks passed
@mattt mattt deleted the mattt/deferred-annotations branch June 28, 2024 17:07
technillogue added a commit that referenced this pull request Aug 30, 2024
This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on __signature__ or partial.
technillogue added a commit that referenced this pull request Sep 13, 2024
This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on __signature__ or partial.
technillogue added a commit that referenced this pull request Sep 13, 2024
This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on __signature__ or partial.
technillogue added a commit that referenced this pull request Sep 13, 2024
This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on __signature__ or partial.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle from future import annotations
1 participant