Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Handle predictors with deferred annotations (#1772)" #1918

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

technillogue
Copy link
Contributor

@technillogue technillogue commented Aug 30, 2024

This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on signature or partial.

I'm suggesting merging this ahead of #1895 to unblock certain language models that have been broken

@technillogue technillogue force-pushed the syl/revert-deferred-annotations branch from 49fc5a5 to 163777b Compare September 13, 2024 19:58
This reverts commit 05900a7.

This is needed to avoid breaking predictors that rely on __signature__ or partial.
@technillogue technillogue force-pushed the syl/revert-deferred-annotations branch from 163777b to cc545ae Compare September 13, 2024 20:00
@technillogue technillogue merged commit f76e4d5 into main Sep 13, 2024
15 checks passed
@technillogue technillogue deleted the syl/revert-deferred-annotations branch September 13, 2024 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants